This may very well have been a violation of your rights, although more information is needed. In Massachusetts, a reasonable apprehension of danger to a police officer justifies an exit order from a motor vehicle. At a motion to suppress hearing, the police officer would have to demonstrate to the court that he/she reasonably feared for their safety or for the safety of fellow officers in order to justify removing you from the car. The state might also argue that your removal from the car was a practical necessity in order to obtain your identification to issue you a civil citation for smoking marijuana in public. I do not know if you were ever cited for a civil infraction.

In terms of the search, more information is needed. In order to justify a "pat frisk" for potential weapons, the police would again have to rely on an argument that you posed a threat to officer safety based on their observations. Courts have found such safety apprehensions "reasonable" where police have observed individuals acting erratically or reaching for unknown objects.

If the search went beyond a "pat frisk" then probable cause of a crime is the standard. Because possessing marijuana is no longer a crime in Massachusetts, probable cause to search someone can no longer be based on information that a person may have marijuana on their person.

If you are a passenger in a car that was stopped legally, then yes, the officer can ask for your id. When the car is stopped ALL people in it are stopped, and the officer gets certain abilities to search and/or ask for ID as a result. If you were simply on the street and and officer asked for your id you can so no and walk away, but not in a traffic stop. Keep in mind that smoking weed in a car is still not legal, even though general consumption is. If there was no further legal action taken, there is really nothing to challenge so even if your rights had been violated, there wouldn't be anything to challenge.