My wife is looking into consulting with a local immigration lawyer here in Morocco to file an I - 130 form with a waiver

I am not aware of any U.S. immigration lawyers in Morocco but a U.S. immigration attorney is more likely to be familiar with the I-130 process as...

My wife apply I-730 8 months before

Look up the usual processing time at the USCIS internet and inquire every 30 days thereafter. You don't have a right to a work permit now.

I need immigration attorney

make an INFOPASS and inquire on teh status of your case advising the Officer you are a DV case and it must be approved by 9-30. I would do this...

As long as you file for H1B while either you are in H-4 status or have an H-4 extension pending then you are fine.

Gathering immigration

petition through brother will take 10-12 years. If his PR daughter is over 21 and will be a U.S. citizen then this would be an immediate relative...

If someone leaves to US and has a 10 yr green card how long before they need to come back so it doesn t expire

There is not a set number of days. It is an issue of intent. If he is moving back permanently he needs to decide if he needs to keep up the green...

The American Embassy called my husband after his case has been in Administrative Processing for more than 7 months.......

In some cases they request a joint interview to assess bona fides of the marriage; they may have been inquiring if this was a feasible option.

Can I file I-485 for adjustment of status if I-130 approved and Priority date current?

It depends on what category your I-130 is in. If it is not the immediate relative category then you will need to show you have always maintained...

Can I-539 be applied if one is still pending

Yes that is an option just include the receipt from the currently pending I-539 and they will adjudicate that first.

Question on J-1 hardship waiver

it is not that unusual. They also usually want a statement about why you don't want to return (which they may share with the sponsor).