A second legal opinion is always a good thing, and sometimes even a third one. A highly competent, professional attorney will welcome the input of other colleagues -- so I encourage you to go consult with another attorney and take all your relevant documents with you. From what you have said above, it sounds like you have never left the U.S. after accruing unlawful presence. If that is the case, your attorney is correct. You are not yet subject to the 3 or 10 year bars under INA 212(a)(9)(B) for "unlawful presence" because these bars do not kick in until you LEAVE the U.S. So, if you have 245(I) eligibility and a current or nearly current DV lottery selection number, by all means, adjust your status. You will NOT be able to leave the U.S. to undergo consular processing though, because then you WOULD have the 3 and 10 year bars, and would need to be eligible for and be approved for a waiver. With adjustment, your attorney will need to make sure everything moves along quickly and you receive final approval before the end of the fiscal year.
There is also a 10 year bar to adjusting status for violating the terms of the voluntary departure order. Hopefully the 10 years for that are over. Very interesting issues. Be sure to hire an experienced immigration attorney for this case. Best regards.
You are outside of the country. The illegal presence is in place. YOu are not eligible for DV lottery unless 245i. Since you say, and I have to take your word for it, 245i eligible, you would have qualified for adjustment of status despite being out of status. THat however is not the case, since you are not in the USA. HEnce, again - DV lottery - not happening for you.
NYC EXPERIENCED IMMIGRATION ATTORNEYS www.myattorneyusa.com; email: firstname.lastname@example.org; Phone: (866) 456-8654; Fax: 212-964-0440; Cell: 212-202-0325. The information contained in this answer is provided for informational purposes only, and should not be construed as legal advice on any subject matter.